Skip to content

fix(#586): flagging a pkgver out of date no longer flags newer versions - #711

Closed
m1rm wants to merge 1 commit into
archlinux:masterfrom
m1rm:586-bugfix-flagging-versions
Closed

fix(#586): flagging a pkgver out of date no longer flags newer versions#711
m1rm wants to merge 1 commit into
archlinux:masterfrom
m1rm:586-bugfix-flagging-versions

Conversation

@m1rm

@m1rm m1rm commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This pull request:

  • adds a version filter when flagging a package out of date: alpm.vercmp(peer.full_version, self.full_version) <= 0. This is the core fix for Flagging an old version should not flag newer versions #586
  • refactors the core logic of flagging into flag_peers() which makes the code a bit more DRY
  • adds a test for flagging packages behavior

Relates to: #586

@m1rm

m1rm commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

I think this PR and the associated bug can be closed because manually flagging is disabled? #719 cc @jelly

@jelly

jelly commented Aug 17, 2026

Copy link
Copy Markdown
Member

Thanks, makes sense!

@jelly jelly closed this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants