ci: Use client-id for the GitHub App token - #88
Merged
Conversation
`actions/create-github-app-token@v3` renamed `app-id` to `client-id` and attached a deprecation message to the old name, which every run that mints a token now prints as a warning. The input is passed straight through to `@octokit/auth-app` as `appId`, which accepts an App ID or a client ID, so the existing `TOKEN_APP_ID` secret works unchanged and callers need no update. actionlint's bundled metadata for the action predates the rename, so it reports `client-id` as unknown and `app-id` as missing. Filter those two messages in `actionlint.yaml` until it refreshes; the patterns name the action, so a genuine typo in either input is still caught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/create-github-app-token@v3renamedapp-idtoclient-idand attached a deprecation message to the old name, which every run that mints a token now prints as a warning. The input is passed straight through to@octokit/auth-appasappId, which accepts an App ID or a client ID, so the existingTOKEN_APP_IDsecret works unchanged and callers need no update.actionlint's bundled metadata for the action predates the rename, so it reports
client-idas unknown andapp-idas missing. Filter those two messages inactionlint.yamluntil it refreshes; the patterns name the action, so a genuine typo in either input is still caught.