chore: Update Rust to v1.98 - #28
Merged
Merged
Conversation
Repin the fenix toolchain hash in flake.nix; without it every nix build fails on a hash mismatch against the 1.92 pin. clippy::from_iter_instead_of_collect was removed upstream, so the xclippy alias emitted renamed_and_removed_lints. Under the CI action's default RUSTFLAGS=-D warnings that was a hard error, not a warning. Replace both warning-denial mechanisms with build.warnings, stabilized in 1.97. It applies to local packages only, so a warning in a dependency no longer fails the build, and it stays out of RUSTFLAGS, so it no longer invalidates the dependency build cache.
The alias existed because clippy had no project-wide lint configuration. Cargo's [lints] tables cover that now, so the lint set moves to [workspace.lints] and both members inherit it. CI lint jobs call cargo clippy directly with the full argument list. Dropping the alias removes .cargo/config.toml entirely, so build.warnings moves to CARGO_BUILD_WARNINGS in the CI workflow and the flake's clippy check. Local builds warn rather than fail. Because the lints now travel with the manifest instead of one alias, they apply to every cargo invocation, including the flake's clippy check, which previously ran with only clippy's defaults.
samuelburnham
enabled auto-merge (squash)
August 22, 2026 18:58
arthurpaulino
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.