SSL: Add peer certificate verification - #2390
Open
petermm wants to merge 3 commits into
Open
Conversation
Support verify_peer with caller-provided CA certificates or CA files, and use the ESP32 IDF certificate bundle when requested. Require a verification name for peer verification, return stable CA option errors, and close sockets on every failed TLS setup path. Map TLS close and socket reset failures to stable SSL errors, and add coverage for CA verification, option errors, and ESP32 HTTPS connections. Signed-off-by: Peter M <petermm@gmail.com>
Signed-off-by: Peter M <petermm@gmail.com>
petermm
force-pushed
the
feature/esp32-ssl
branch
4 times, most recently
from
August 31, 2026 08:04
6cfbe40 to
2d16d62
Compare
Exercise CYW43 WiFi, DHCP, SNTP, certificate time checks, and verified HTTPS on Pico W in Wokwi. Add a combined UF2 target, token-gated CI workflow, and local build instructions. Run the Wokwi-only network case last and retain its final VM context because the RP2 network port does not yet support full teardown. Signed-off-by: Peter M <petermm@gmail.com>
petermm
force-pushed
the
feature/esp32-ssl
branch
from
August 31, 2026 09:27
2d16d62 to
4603168
Compare
Contributor
Author
|
upon further review it turns out we should default to CONFIG_MBEDTLS_HAVE_TIME_DATE=y - as to default validate that cert is within it's valid period. Requires a decent time set - building with CONFIG_MBEDTLS_HAVE_TIME_DATE=n, disables the time validation, for those scenarios. we should also kinda not suggest people to use verify_none. the rp2 simtest CI is there for good measure, I suggest moving that to other PR before merge and then a squash, but good to validate it rp2 while we iterate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
good old secops - obviously good for general use, and things like https://github.com/nerves-hub/nerves_hub_link_atomvm_esp32 so they dont need a custom nif for websocket..
Support verify_peer with caller-provided CA certificates or CA files, and use the ESP32 IDF certificate bundle when requested.
Require a verification name for peer verification, return stable CA option errors, and close sockets on every failed TLS setup path.
Map TLS close and socket reset failures to stable SSL errors, and add coverage for CA verification, option errors, and ESP32 HTTPS connections.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later