refactor(project): simplify code-based evaluator scaffolding - #2255
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
The change is self-consistent and cleanly scoped to what the description promises:
--metricand--modelflags are fully removed fromhandlers/project/add/evaluator/code-based/index.ts, along with their parsers (parseMetric,resolveBedrock Model).EVALUATOR_LIBRARIES/EvaluatorLibraryare dropped fromhandlers/project/types.ts, andManagedEvaluatorScaffoldInputno longer carriesmetric/model.core/project/templates/evaluator.tscollapses to a singleevaluators/python-lambdaasset dir with aName-only render context.- The
deepeval-lambdaandautoevals-lambdaasset trees are removed; no remaining references insrc/(only the test line that asserts the removed flags reject). - Tests are updated to cover managed-with-timeout, managed-default,
--timeout-secondsincompatibility with--lambda-arn, and rejection of the removed flags viacommander.unknownOption. - No TUI screen depended on the removed inputs (
isValidBedrockModelIdis retained for the llm-as-a-judge handler and TUI, which still need it). - Existing on-disk evaluator specs are unaffected —
metric/modelwere scaffolder inputs only, not part of theEvaluatorschema.
No changes required before merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2255 +/- ##
============================================
- Coverage 97.04% 97.03% -0.01%
============================================
Files 566 566
Lines 39409 39345 -64
============================================
- Hits 38244 38180 -64
Misses 1165 1165 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jariy17
marked this pull request as ready for review
September 9, 2026 18:37
Hweinstock
previously approved these changes
Sep 9, 2026
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Hweinstock
approved these changes
Sep 9, 2026
notgitika
approved these changes
Sep 9, 2026
notgitika
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility
Testing
Live verification
Verified with a temporary evaluator-only project in an exploratory AWS account in us-west-2: