refactor(project): clean up project handler tests to use common utils

[Hweinstock]

Problem

Each project test redefined their own version of the same utilities.

Examples:

• agentcore-cli/src/handlers/project/add/runtime/index.test.ts

  Line 43 in b18bb4b

  async function inProject(name = "TestProject"): Promise<string> {

• https://github.com/aws/agentcore-cli/blob/refactor/src/handlers/project/project.test.ts#L58.

Solution

• standardize the temp directory helper, and project initiation in src/testing/projects.ts.

Future Work

• Hoping to also migrate to a more consistent model where handler tests live next to the handler rather than project.test.ts

[agentcore-devx-automation]

Claude Security Review: no high-confidence findings. (run)

[agentcore-devx-automation]

AgentCore Harness Review

Verdict: Looks good

Nice consolidation. Extracting inTempDirectory and initProject into src/testing/ and replacing the per-file originalCwd/tempDirectories boilerplate with a cleanups list makes the tests substantially shorter and more consistent. The refactor is test-only, no production code changes, and it stays on the "real temp directory over fs mock" side of the mocking guidance.

A few minor observations — none blocking:

• src/testing/projects.ts: if root.route([... "create" ...]) throws inside initProject, the temp directory created by inTempDirectory is leaked and cwd isn't restored, since the returned cleanup hasn't reached the caller yet. The previous pattern pushed the temp dir onto a shared array before run, so afterEach still cleaned it. Only matters for failure paths of project create itself, but a try { … } catch { await cleanup(); throw } inside initProject would preserve the old behavior.
• src/handlers/project/project.test.ts: the const cleanups = [] declaration now sits below two tests that reference it (project status requires an AgentCore project, project dev requires an AgentCore project). Works because the test bodies run after module init, but it reads a little surprising — worth hoisting the declaration to the top of the file next to the other module-level state.
• Files with both afterEach(cleanupScreens) and afterEach(() => Promise.all(cleanups…)) rely on registration-order execution. That's what Bun does today, and it matches the prior behavior, so fine as-is — just something to keep in mind if we ever move to another runner.

Happy to see this land.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.04%. Comparing base (4fe2c10) to head (2e2c8d4).

Additional details and impacted files

@@             Coverage Diff              @@
##           refactor    #2256      +/-   ##
============================================
- Coverage     97.04%   97.04%   -0.01%     
============================================
  Files           566      566              
  Lines         39353    39334      -19     
============================================
- Hits          38190    38171      -19     
  Misses         1163     1163              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[agentcore-devx-automation]

Claude Security Review: no high-confidence findings. (run)

[agentcore-devx-automation]

Claude Security Review: no high-confidence findings. (run)

[agentcore-devx-automation]

Claude Security Review: no high-confidence findings. (run)

[agentcore-devx-automation]

Claude Security Review: no high-confidence findings. (run)