ci(release): use dedicated runners for release publishing - #2268
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Changes requested
One substantive concern: the publish job in .github/workflows/release-publish.yml now runs on aws-release-4-core (line 50), but the comment on line 49 still says:
# npm provenance is only issued from GitHub-hosted runners.
runs-on: aws-release-4-coreThat comment is the exact reason the publish job was previously kept on ubuntu-latest, and npm publish --provenance on line 105 depends on it. npm publish --provenance requires the runner to identify as github-hosted (via the RUNNER_ENVIRONMENT OIDC claim); Sigstore/Fulcio rejects tokens from self-hosted runners, and npm's docs are explicit that provenance requires a "cloud-hosted runner". If aws-release-4-core is a self-hosted runner group, this change will break provenance signing on the very next stable release.
Two options depending on what aws-release-4-core actually is:
- If it's a GitHub-hosted larger runner (custom-labeled but still
RUNNER_ENVIRONMENT=github-hosted): the change is fine, but please delete or rewrite the now-contradictory comment on line 49 so the next reader doesn't undo this by mistake. Ideally verify once with a dry run / rc publish that--provenancestill succeeds. - If it's self-hosted (which the "dedicated runner group" / "allowlist" language in the README suggests): revert the
publishjob toruns-on: ubuntu-latestand leave onlycheck-releaseandprepareonaws-release-4-core, then update the README paragraph accordingly (it currently claims all three jobs use the dedicated runner).
Everything else in the diff (moving check-release to aws-release-4-core, the README rewording, the updated TODO comment) looks fine.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2268 +/- ##
=========================================
Coverage 97.04% 97.04%
=========================================
Files 566 566
Lines 39353 39353
=========================================
Hits 38190 38190
Misses 1163 1163 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
Complete the dedicated-runner migration after #2259.
check-releaseandpublishinrelease-publish.ymlfromubuntu-latesttoaws-release-4-core.refactoronly. After this file lands onmain, a runner-group administrator must add itsmainpin before changing the branch filter.No package contents, application code, or test files are changed.
Related Issue
Closes #2267
Follow-up to #2259.
Documentation PR
Not applicable. The release documentation is updated in
.github/workflows/README.md.Type of Change
Testing
The
refactorbranch uses Bun rather than the default branch's separate npm unit/integration scripts.runs-onvalues.bun run buildbun run typecheckbun run lint:checkbun test: 3,179 existing tests passed.Runner-group approval was confirmed separately. No release workflow was dispatched, no npm package was published, and runner allocation was not exercised live during validation. All additional checks stayed outside the repository; no test scripts are included.
Checklist
refactor)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.