Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #10645
Description of changes: On a Korean Windows install whose profile directory contains Hangul, every command fails at startup with
'cp949' codec can't decode byte 0x80. The install script writesawscli/data/install.jsonas UTF-8 and records the install path in it, butget_distribution_source()opens that file with the locale's default encoding, which is cp949 there. It runs on every invocation while building the user agent, so evenaws --versiondies before doing anything.aws updatereads the same file the same way.Both readers now pass
encoding='utf-8', matching how the file is written.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.