Handle named errors when checking S3 buckets - #10647
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s3_bucket_existsconverts every S3 error code to an integer. Named codes such asNoSuchBucketandAccessDeniedtherefore raiseValueError, interrupting the bucket check used byaws configservice subscribe.Use the response HTTP status when available and compare its string representation with
404. Preserve the existing numeric-code fallback and non-404 behavior.Tests: three new regressions fail on the base revision; all 40 tests in
test_utils.pyandconfigservice/test_subscribe.pypass after the change. Tests used mocked requests, dummy credentials, and disabled EC2 metadata access. No live AWS requests were needed.Generated by AI tools (Codex). Human review: [add your name after reviewing, before submitting, as required by CONTRIBUTING.rst].