Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #10648
ConfigFileWriter.update_configreopened the config file withopen(config_filename, 'w'), which truncates it before any of the new contents are written. If that write failed or the process died in between, the file was left at 0 bytes and every profile in it was gone, not just the one being edited. On the shared credentials file that means secret access keys that cannot be fetched again.Description of changes:
Write the new contents to a temporary file in the same directory, copy the original file's permissions onto it, and
os.replace()it over the original, removing the temporary file if anything fails. A failed write now leaves the old file untouched.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.