Skip to content

style: format plugin conformance handlers - #586

Merged
wangyb-A merged 1 commit into
mainfrom
fix/conformance-plugin-spotless
Aug 1, 2026
Merged

style: format plugin conformance handlers#586
wangyb-A merged 1 commit into
mainfrom
fix/conformance-plugin-spotless

Conversation

@wangyb-A

@wangyb-A wangyb-A commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • apply the repository's configured Spotless formatting to six plugin conformance handlers
  • restore a clean project-wide spotless:check
  • make no behavioral changes

spotless check was failing, e.g.: https://github.com/aws/aws-durable-execution-sdk-java/actions/runs/30674290202/job/91298216229?pr=585

Validation

  • mvn -q spotless:check — passed
  • mvn -q -pl conformance-tests package -DskipTests — passed
  • verified the diff contains exactly the six files reported by Spotless

@wangyb-A
wangyb-A temporarily deployed to ai-pr-review-runtime August 1, 2026 00:04 — with GitHub Actions Inactive
@wangyb-A
wangyb-A temporarily deployed to ai-pr-review-runtime August 1, 2026 00:04 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@wangyb-A
wangyb-A marked this pull request as ready for review August 1, 2026 00:06
@wangyb-A
wangyb-A requested a review from a team August 1, 2026 00:06
@wangyb-A
wangyb-A temporarily deployed to ai-pr-review-runtime August 1, 2026 00:06 — with GitHub Actions Inactive
@wangyb-A
wangyb-A temporarily deployed to ai-pr-review-runtime August 1, 2026 00:06 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codex AI review

No actionable findings. The PR only reformats Javadocs and does not change runtime behavior or public APIs. Tests were not run per review constraints; residual risk is limited to formatting validation.

Reviewed commit 66c135c7c21e03bb1b1867f01c2837a93e296b2d. Workflow run

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Claude AI review

No actionable findings.

This PR (style: format plugin conformance handlers) applies Spotless line-wrapping to Javadoc comments in six files under conformance-tests/src/main/java/plugin/. I inspected every hunk in .ai-review-context/pr.diff:

  • PluginFaultyAndHealthy.java, PluginParallelBranchHooks.java, PluginReplayFlags.java, PluginRetryExhaustion.java, PluginWaitOperationHooks.java — comment text is only re-wrapped; wording is byte-for-byte identical apart from where line breaks fall.
  • PluginSupport.java — same re-wrapping, plus one single-line /** ... */ on isStep expanded to a multi-line block. No change to the method body or the "STEP".equals(type) logic.

There are no changes to executable code, method signatures, generics, serialization, checkpoint/replay logic, plugin lifecycle, or concurrency behavior. The PR is behavior-preserving as described.

Residual test risk: None from a runtime standpoint — comment-only changes cannot alter behavior, so no new or updated tests are warranted. The only thing this diff cannot itself prove is that the wrapped output actually satisfies spotless:check; that is validated by CI's mvn spotless:check (which the PR states now passes) rather than by any test in this repo.

Reviewed commit 66c135c7c21e03bb1b1867f01c2837a93e296b2d. Workflow run

@hln33
hln33 self-requested a review August 1, 2026 00:09

@hln33 hln33 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wangyb-A
wangyb-A merged commit 0624f9c into main Aug 1, 2026
30 checks passed
@wangyb-A
wangyb-A deleted the fix/conformance-plugin-spotless branch August 1, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants