Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions .github/workflows/check-spotless.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,25 @@
# proper import ordering, and license headers.
# Fails the build if any violations are found.
#
# Deliberately has no `paths` filter: `mvn spotless:check` runs across every
# Maven module, so filtering by path would skip the job for changes it still
# validates. A module missing from such a filter (e.g. otel-plugin) can merge
# unformatted code and then break this check on unrelated pull requests.
#
# Triggers:
# - pull_request
# - pull_request: every PR targeting main
# - push: main, to catch any formatting drift that lands
# - workflow_dispatch: manual run
name: Spotless

on:
workflow_dispatch:
pull_request:
branches:
- main
paths:
- 'sdk/**'
- 'sdk-testing/**'
- 'sdk-integration-tests/**'
- 'examples/**'
push:
branches:
- main

permissions:
contents: read
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -429,8 +429,17 @@ void operationEnd_withNonSuccessStatusAndNoError_leavesOperationSpanUnset() {
plugin.onOperationStart(
new OperationInfo("op-cancel", "step-cancel", "STEP", "Step", null, Instant.now(), null, false));
plugin.onOperationEnd(new OperationEndInfo(
"op-cancel", "step-cancel", "STEP", "Step", null, Instant.now(), Instant.now(), "CANCELLED", null,
false, null));
"op-cancel",
"step-cancel",
"STEP",
"Step",
null,
Instant.now(),
Instant.now(),
"CANCELLED",
null,
false,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-1", ARN, true, InvocationStatus.SUCCEEDED, null));

var operationSpan = spanByName(spanExporter.getFinishedSpanItems(), "step-cancel");
Expand All @@ -443,8 +452,17 @@ void operationEnd_withoutStart_nonSuccessStatusAndNoError_leavesContinuationSpan
// TIMED_OUT terminal status must NOT be stamped OK.
plugin.onInvocationStart(new InvocationInfo("req-2", ARN, false, Instant.now()));
plugin.onOperationEnd(new OperationEndInfo(
"op-cb-timeout", "my-callback", "CALLBACK", "Callback", null, Instant.now(), Instant.now(),
"TIMED_OUT", null, false, null));
"op-cb-timeout",
"my-callback",
"CALLBACK",
"Callback",
null,
Instant.now(),
Instant.now(),
"TIMED_OUT",
null,
false,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-2", ARN, false, InvocationStatus.SUCCEEDED, null));

var continuationSpan = spanByName(spanExporter.getFinishedSpanItems(), "my-callback");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -501,8 +501,17 @@ void operationEnd_withNonSuccessStatusAndNoError_leavesOperationSpanUnset() {
plugin.onOperationStart(
new OperationInfo("op-cancel", "step-cancel", "STEP", "Step", null, Instant.now(), null, false));
plugin.onOperationEnd(new OperationEndInfo(
"op-cancel", "step-cancel", "STEP", "Step", null, Instant.now(), Instant.now(), "CANCELLED", null,
false, null));
"op-cancel",
"step-cancel",
"STEP",
"Step",
null,
Instant.now(),
Instant.now(),
"CANCELLED",
null,
false,
null));

plugin.onInvocationEnd(new InvocationEndInfo("req-1", "arn:exec1", true, InvocationStatus.SUCCEEDED, null));

Expand All @@ -520,8 +529,17 @@ void operationEnd_withoutMatchingStart_nonSuccessStatusAndNoError_leavesContinua
plugin.onInvocationStart(new InvocationInfo("req-1", "arn:exec1", true, Instant.now()));

plugin.onOperationEnd(new OperationEndInfo(
"op-cb-timeout", "my-callback", "CALLBACK", "Callback", null, Instant.now(), Instant.now(),
"TIMED_OUT", null, false, null));
"op-cb-timeout",
"my-callback",
"CALLBACK",
"Callback",
null,
Instant.now(),
Instant.now(),
"TIMED_OUT",
null,
false,
null));

plugin.onInvocationEnd(new InvocationEndInfo("req-1", "arn:exec1", true, InvocationStatus.SUCCEEDED, null));

Expand Down
Loading