fix(otel): preserve configured service name - #593
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codex AI reviewNo actionable findings. Residual risk: read-only review; the updated OpenTelemetry tests were not executed. Reviewed commit |
Claude AI reviewReviewVerdict: No actionable findings — the change is correct and adequately tested. The PR removes the constructor code in Checks performed:
No correctness, generics/typing, serialization, replay, suspension/retry, concurrency, or lifecycle regressions were introduced. Residual note (non-blocking, unchanged lines)This PR removes the only production usage of Test riskLow. The unit test covers both exported span types for the preserved name. Residual: there is no negative-path assertion confirming a default/unset service name when the caller configures none, and no integration/replay-level test asserting service name preservation across suspend/resume invocations — minor, given the unit coverage. Reviewed commit |
Summary
ExecutionOtelPluginfrom overriding the caller-configured OpenTelemetry resourceservice.nameInvocationOtelPlugin, Python, and TypeScriptTesting
mvn -pl otel-plugin test(145 tests)mvn -pl otel-plugin spotless:applygit diff --checkRelated change