-
Notifications
You must be signed in to change notification settings - Fork 1
fix: align supported Typer and Click ranges for #360 #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,6 +37,53 @@ jobs: | |
| - name: Run adapter and Beacon compatibility tests | ||
| run: python -m pytest tests/test_typer_adapter.py compatibility/consumers/beacon_typer/tests | ||
|
|
||
| typer-click-boundaries: | ||
| name: Typer ${{ matrix.typer-version }} / Click ${{ matrix.click-version }} / Python ${{ matrix.python-version }} | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 20 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - python-version: "3.10" | ||
| typer-version: "0.25.1" | ||
| click-version: "8.2.1" | ||
| - python-version: "3.14" | ||
| typer-version: "0.25.1" | ||
| click-version: "8.2.1" | ||
| - python-version: "3.10" | ||
| typer-version: "0.25.1" | ||
| click-version: "8.5.0" | ||
| - python-version: "3.14" | ||
| typer-version: "0.25.1" | ||
| click-version: "8.5.0" | ||
| - python-version: "3.10" | ||
| typer-version: "0.27.2" | ||
| click-version: "8.2.1" | ||
| - python-version: "3.14" | ||
| typer-version: "0.27.2" | ||
| click-version: "8.2.1" | ||
| - python-version: "3.10" | ||
| typer-version: "0.27.2" | ||
| click-version: "8.5.0" | ||
| - python-version: "3.14" | ||
| typer-version: "0.27.2" | ||
| click-version: "8.5.0" | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - name: Set up Python | ||
| uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - name: Install framework and supported Typer adapter | ||
| run: python -m pip install ".[dev,typer]" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correctness/CI risk: the new |
||
| - name: Pin the tested Click/Typer boundary pair | ||
| run: python -m pip install --upgrade "click==${{ matrix.click-version }}" "typer==${{ matrix.typer-version }}" | ||
| - name: Install Beacon fixture without dependency resolution | ||
| run: python -m pip install --no-deps compatibility/consumers/beacon_typer | ||
| - name: Run adapter and Beacon compatibility tests | ||
| run: python -m pytest tests/test_typer_adapter.py compatibility/consumers/beacon_typer/tests | ||
|
|
||
| downstream: | ||
| name: Install and test independent consumers | ||
| runs-on: ubuntu-latest | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintainability: this 8-entry
matrix.includeis a full cross product of three 2-value axes written out by hand instead of plain matrix arrays. A future edit to add a third value to any axis requires manually appending 4 more entries, and a copy-paste slip could silently produce a duplicate combination + a missing one with no test catching it. Suggestpython-version: ["3.10","3.14"],typer-version: ["0.25.1","0.27.2"],click-version: ["8.2.1","8.5.0"]for the identical cross product with no duplication risk.