fix: finalize run outcomes and metadata - #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run.jsonlifecycle authority into the core so every owned invocation is finalized with a canonical outcome, exit code, end time, and duration while optional history remains enrichment-only.SystemExit, and unexpected exceptions through one failure-safe process boundary, including consistent handling for malformed custom Click exit codes.ConfigurationErrorcontract for messages that are safe to show as usage errors.Issue
Closes #52
Part of #50.
Validation
.venv/bin/python -m pytest— 163 passed, 19 subtests passed.venv/bin/python -m compileall -q lib/python tests./tests/validate.sh.venv/bin/python -m build --sdist --wheel --outdir <temporary-directory>.venv/bin/python scripts/validate_package_artifact.py <temporary-directory>git diff --checkNotes
log_to_file=Falseremain outside owned run-bundle persistence by design.base_cli.ConfigurationError; arbitraryValueError,RuntimeError, andOSErrorinstances are treated as private unexpected failures.Checklist
<category>/<issue>-<YYYYMMDD>-<slug>, and its category prefix matches the issue's single standard category label.Fixes #<issue>orCloses #<issue>when merge should close the issue.