perf(core): bound sqlite-vec reconciliation work - #1582
Closed
nogueirathiago wants to merge 1 commit into
Closed
nogueirathiago wants to merge 1 commit into
nogueirathiago wants to merge 1 commit into
Conversation
Signed-off-by: Thiago Henrique Nogueira <thnogueira+SEDUCSP@apoioprodesp.sp.gov.br>
|
Thiago Henrique Nogueira seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
Closing because this change is intended to remain in the personal fork, not be proposed upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous correlated DELETE can repeatedly scan the sqlite-vec virtual table for every manifest row. On large projects this leaves reindex CPU-bound in reconciliation even after embedding work has completed.
The new flow resolves rowids from the indexed relational manifest first, then performs direct virtual-table rowid deletes. Project-scoped stale cleanup and global ownerless-orphan cleanup retain their existing behavior.
Validation
Environment limitation
The Postgres and real-Redis Docker suites could not run because the local Docker daemon was not available. The change is isolated to the SQLite sqlite-vec adapter.