Skip to content

fix(pypi): do not return rctx.metadata for pip_archive #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 2 commits into from
Aug 14, 2026
+5 −1
Merged

fix(pypi): do not return rctx.metadata for pip_archive #4043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b38355f
fix(pypi): do not return rctx.metadata for pip_archive
aignas Aug 14, 2026
33e3bae
Rename 4042.fixed.md to 4043.fixed.md
aignas Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/4043.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Previous refactor that shipped with 2.3 introduced regression for the experimental repository cache
users. This restores the previous behavior ([#3791](https://github.com/bazel-contrib/rules_python/pull/3791)).
4 changes: 3 additions & 1 deletion python/private/pypi/whl_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,9 @@ def _pip_archive_impl(rctx):
if not rctx.delete("whl_file.json"):
fail("failed to delete the whl_file.json file")

return _whl_extract(rctx, whl_path = whl_path, logger = logger, sdist_filename = sdist_filename)
# NOTE @aignas 2026-08-14: We never return rctx.metadata for pip archives because the result may
# not be reproducible across all machines given the input args to the repository rule.
_whl_extract(rctx, whl_path = whl_path, logger = logger, sdist_filename = sdist_filename)

def _remove_files(rctx, *basenames):
paths = list(rctx.path(".").readdir())
Expand Down