refactor: split code into multiple files - #4044
Draft
aignas wants to merge 2 commits into
Draft
Conversation
There was a small regression in bazel-contrib#3948 that may affect experimental repository cache users. Related to bazel-contrib#3791
This move the compatibility shim to the macro for the `dep_template` and since we may set it to an empty string in the future, we do not set it to mandatory. This resulted in a few test fixes for the `pip_archive`. This will hopefully make working with the code easier. The attribute reuse is done in this way on purpose - the most basic repository rules are being used as a basis for the definition of the attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A followup to #4043 to split code into multiple files to make the interaction
and reuse more intentional and explicit.
Work towards #2948.