Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .agents/skills/review-code/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ file from `.agents/skills/review-code/`:

### Action Instructions
- Launch all sub-agents concurrently using `invoke_subagent`.
- Collect the reports from each sub-agent and report all violations and
suggested improvements clearly with suggested fixes for the user.
- If all domain audits pass, confirm that the PR is ready for review.
- Collect the reports from each sub-agent.
- Create a user-facing review artifact named `code-review-results.md` in the
conversation artifact directory. The artifact must include:
- Overall summary and verdict across audit categories.
- Detailed analysis and findings from each sub-agent.
- Actionable findings and fix suggestions with specific code snippets, diffs,
and clickable file links for any violations found.
- In the response, provide a concise summary with the overall verdict and a
clickable markdown link to `code-review-results.md`.
3 changes: 1 addition & 2 deletions .agents/skills/review-code/review-agents-prompt.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@ against `AGENTS.md`:
5. Check that all repo rules and macro conventions described in `AGENTS.md`
are respected.

Report any violations found clearly with actionable suggested fixes, or report
that the changes pass project conventions audit.
@.agents/skills/review-code/review-report-format.md
3 changes: 1 addition & 2 deletions .agents/skills/review-code/review-contributing-prompt.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,4 @@ and PR metadata against `CONTRIBUTING.md` and project rules:
5. Ensure style and conventions described in `CONTRIBUTING.md` are respected
across all changes.

Report any violations found clearly with actionable suggested fixes, or report
that the changes pass contribution audit.
@.agents/skills/review-code/review-report-format.md
3 changes: 1 addition & 2 deletions .agents/skills/review-code/review-docs-prompt.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,4 @@ in `git diff` against the project's documentation rules:
`.agents/rules/news.md` and `CONTRIBUTING.md` (proper `<id>.<category>.md`
name, no leading bullets, subsystem prefix, `{obj}` refs, issue links).

Report any violations found clearly with actionable suggested fixes, or report
that the documentation changes pass audit.
@.agents/skills/review-code/review-report-format.md
3 changes: 1 addition & 2 deletions .agents/skills/review-code/review-pr-standards-prompt.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ Your sole task is to audit PR titles and PR descriptions against
rebase existing commits (create new commits and merges instead, to preserve
code review comment threads).

Report any violations found clearly with actionable suggested fixes, or report
that the PR standards pass audit.
@.agents/skills/review-code/review-report-format.md
3 changes: 1 addition & 2 deletions .agents/skills/review-code/review-python-prompt.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,4 @@ Your sole task is to audit all Python source (`.py`) and test changes in
4. Verify that tests were executed using Bazel
(`bazel test --config=fast-tests`) and passed.

Report any violations found clearly with actionable suggested fixes, or report
that the Python changes pass audit.
@.agents/skills/review-code/review-report-format.md
6 changes: 6 additions & 0 deletions .agents/skills/review-code/review-report-format.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Provide a structured report containing:
- Status: PASS, WARNING, ACTION_REQUIRED, USER_DECISION_REQUIRED, or
NOT_APPLICABLE
- Detailed analysis and findings for each item checked
- Actionable findings and fix suggestions with specific code snippets, diffs,
and clickable file links for any violations found
3 changes: 1 addition & 2 deletions .agents/skills/review-code/review-starlark-prompt.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ in `git diff` against the project's Starlark coding rules and conventions:
(`"""`), and do NOT use trailing backslashes (`\`) on opening triple-quotes.
6. Verify analysis tests use `rules_testing`, not `bazel_skylib`.

Report any violations found clearly with actionable suggested fixes, or report
that the Starlark changes pass audit.
@.agents/skills/review-code/review-report-format.md