feat(transparency): make the signing wire operable — GT-588 criterion 1 - #111
Merged
Merged
Conversation
The wire existed and was tested: a decorator over IAuditEntryRepository, a
Merkle tree, COSE_Sign1, a JSONL ledger and a cross-language interop job in CI.
And still nothing was signed in any environment, for a reason that was not in
the code — the chart did not declare the switch. Transparency appeared in no
values.yaml, no configmap and no deployment, so an operator holding real keys
had no way to turn it on short of inventing a --set over a key that does not
exist, which Helm accepts in silence and which enables nothing.
What ships:
- values.yaml declares the switch, OFF, with the ledger path, the issuer and
transparency-service identities and the names of the secret keys.
- the configmap emits the non-secret keys ONLY when signing is on, for the
same reason Otlp does: a key present in the configmap suggests there is a
signed record when there is not.
- the deployment reads both Ed25519 seeds from an existing Secret. The chart
never generates, defaults or versions key material.
- the ledger gets its own volume, and asking for persistence without a claim
FAILS the render rather than quietly mounting an emptyDir under the name of
a persistent volume. A ledger erased on every restart is what the gap calls
decorative.
Five tests read the CHART rather than the code, on purpose: what was missing was
the operating surface, and a test over the classes would have stayed green for
as long as the gap was open. One of them asserts the default is still OFF —
verified by flipping it to true and watching it go red. Another asserts the wire
stays a DECORATOR: a list of explicit callers only signs the paths somebody
remembered.
The criterion is still NOT met and the row says so: no environment enables this
yet, and doing so needs key custody, which is an owner decision rather than a
code change. What changed is that it is now a deployment decision instead of
being impossible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wire existed and was tested — a decorator over
IAuditEntryRepository, a Merkle tree, COSE_Sign1, a JSONL ledger, and a cross-language interop job in CI. And still nothing was signed in any environment, for a reason that was not in the code: the chart did not declare the switch.Transparencyappeared in novalues.yaml, no configmap and no deployment. An operator holding real keys had no way to turn it on short of inventing a--setover a key that does not exist — which Helm accepts in silence and which enables nothing.What ships
values.yamlOtlp: a key in the configmap suggests there is a signed record when there is notemptyDirunder the name of a persistent volumeA ledger on the pod's ephemeral filesystem is erased on every restart, and a transparency log that deletes itself is exactly what the gap calls decorative.
The tests read the chart, not the code
Deliberately. What was missing was the operating surface, and a test over the classes would have stayed green for the whole time the gap was open — the same lesson
ObservabilityConventionTestsalready recorded for traces.trueand watching the test go red, not assumed.The criterion is still not met, and the row says so
No environment enables this yet. Doing so needs two distinct Ed25519 seeds in a secret store and a PVC — key custody is an owner decision, not a code change. What changed is that it went from impossible without touching code to a deployment decision, and
product/infra/helm/README.mdnow documents exactly how.🤖 Generated with Claude Code