BUG Change the name of GEO from GEO600 to G1 - #935
Open
transientlunatic wants to merge 3 commits into
Open
Conversation
Signed-off-by: Daniel Williams <daniel.williams@ligo.org>
transientlunatic
changed the title
GEO600' to G1'GEO600 to G1
Collaborator
|
I'm in favour of this in principle, I suspect not many people are using GEO, but it would be good to ensure backward compatibility if possible. |
Collaborator
|
@transientlunatic it would be nice to see this merged before the EoL for GEO. Do you have capacity to address Colm's comment above? I also think there are some unrelated changes that shouldn't be in the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies in advance if this is the wrong way to handle this.
When trying to analyse data contained in GEO frames, which have channel names prefixed with
G1I ran into problems, as bilby_pipe is unable to understand (I think) a channel list where the channel isn't prefixed with the name of the detector as understood by bilby. So bilby was expecting to open GEO600:channel_name but this was stored in G1:channel_name.I think it's possible this might be handled in bilby_pipe as well, though this approach does fix the problem.