Wake concurrent requests on EOF - #225
Merged
oleonardolima merged 1 commit intoAug 20, 2026
Merged
Conversation
This was referenced Aug 18, 2026
Tokio runtime shutdown does not abort tasks created via
spawn_blocking
lightningdevkit/ldk-node#1007
Open
A clean EOF currently returns only to the thread reading the connection. Other callers remain blocked on their response channels indefinitely. Treat EOF like other shared I/O failures so every pending request is notified and can participate in connection recovery. Co-Authored-By: HAL 9000
oleonardolima
force-pushed
the
2026-08-wake-electrum-waiters-on-eof
branch
from
August 20, 2026 14:21
df535ef to
944d5cb
Compare
oleonardolima
approved these changes
Aug 20, 2026
oleonardolima
left a comment
oleonardolima
left a comment
Contributor
There was a problem hiding this comment.
self-ACK 944d5cb
I renamed and also signed the commit (which was missing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A clean EOF currently returns only to the thread reading the connection. Other callers remain blocked on their response channels indefinitely.
Treat EOF like other shared I/O failures so every pending request is notified and can participate in connection recovery.
Co-Authored-By: HAL 9000
Changelog notice
Checklists
All Submissions:
Bugfixes: