Fix ConcurrentLfu Trim thread safety - #818
Merged
Merged
Conversation
bitfaster
changed the title
|
coverage: 99.226% (+0.07%) from 99.158% — users/alexpeck/trimsafety into main |
RuneH-MSFT
approved these changes
Aug 26, 2026
RuneH-MSFT
left a comment
RuneH-MSFT
left a comment
There was a problem hiding this comment.
Looks good. Left one minor comment.
added 2 commits
August 25, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #795 regressed
ConcurrentLfu.Trim(n). In order to specify the item removed reason,TryRemovewas switched toEvict. However,Evictis required to hold the maintenance lock.Fix is to move all
Evictcalls inside the maintenance lock.