fix(acp): admit explicit allowlist authors only in verified DMs - #7642
Open
KanjiTheryo wants to merge 1 commit into
Open
KanjiTheryo wants to merge 1 commit into
KanjiTheryo wants to merge 1 commit into
Conversation
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selected-people /
--respond-to=allowlistcurrently admits listed authors in group channels but drops their 1:1 DMs. The inbound author gate treats DMs as owner/sibling-only, so an allowlisted person can talk to the agent in a stream and then look like a dead agent in DM.This change admits explicit allowlist keys only in verified DMs. It does not open DMs for
anyone, and missing/failed/unrecognized channel metadata never grants an external author access.owner-onlyallowlistanyonenobodyRemoving a key from the effective allowlist revokes admission. Signature checks, membership, workflow attribution, and session/audience boundaries are unchanged. Normal and setup listeners share the policy.
Closest existing PRs
CONTRIBUTING asked for a duplicate search. Closest open work:
--allow-dm-allowlist(default off). Sameanyone/DM caution; this PR makes verified-DM allowlist the documented meaning ofallowlistinstead of a second flag.anyone= every author. This PR keepsanyoneowner/sibling-only in DMs to avoid the transitive DM hole.Happy to close this in favor of one of those if maintainers prefer that shape.
Related: #4487 (respond-to not reaching the running process is separate; this only fixes the author gate).
Testing
bin/cargo test -p buzz-acp author_gate: 29 passed, includingdm_allowlist::signed_dm_policy_matrix_and_revocationand production-listener DM boundaries.Rosie/Theryo runtime notes stay on our private fork and are not in this PR.