Skip to content

fix(desktop): show the community icon in the sidebar profile card - #7658

Draft
sbddesign wants to merge 1 commit into
block:mainfrom
sbddesign:fix/relay-branding-consistency
Draft

sbddesign wants to merge 1 commit into
block:mainfrom
sbddesign:fix/relay-branding-consistency

Conversation

@sbddesign

@sbddesign sbddesign commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

The sidebar profile card always renders 🐝 next to the active community name, even when the account menu and community rail show a custom relay icon. This is visible on the card normally, or on hover when a user status occupies the secondary line.

Use the same active-community icon query and CommunityEmojiIcon renderer as the account menu. Allow the renderer's caller to supply the smaller square dimensions used by the profile card. Existing default-icon behavior remains available when no icon is returned.

Related issue

Related: #2797. No duplicate profile-card icon fix found among open PRs.

The investigation also confirmed a separate name mismatch: a self-hosted relay at buzz.atlbitlab.com serves the correct custom lightning icon but the hardcoded NIP-11 name Buzz Relay. Desktop's ATL BitLab label is device-local; mobile derives buzz from the first hostname segment during pairing and independently fetches the relay icon. This is not cross-relay propagation lag. The same name derivation appears in mobile-v0.15.0-rc.2; the exact installed App Store binary was not inspected.

This PR fixes the desktop icon. It does not close #2797 or change local name ownership, relay metadata, or mobile naming. Existing open PRs #5234 (hostname fallback) and #6632 (mobile local rename) also address parts of that separate limitation.

Testing

  • Full desktop unit suite: 6,500 passed.
  • pnpm --dir desktop build:e2e: passed, including TypeScript compilation.
  • Playwright sidebar-community-icon.spec.ts: 2 passed in Chromium, using the mock native bridge. Covers normal card, status hover, account-menu parity, no-icon fallback, and switching to a community without an icon.
  • Desktop lint/format and text-size checks: passed; existing informational lint suggestions remain elsewhere.
  • Full env -u BUZZ_ACP_LAZY_POOL -u BUZZ_ACP_IDLE_POOL_SLEEP just ci: passed at e855fd74b, including Rust/Tauri lint and tests, production desktop/web builds, and 2,121 mobile tests. The first run inherited managed-agent pool options and failed two default-value tests in buzz-acp; removing those options only for the test process resolved both failures without source changes.
  • Actual relay NIP-11 was read without changing it. No packaged desktop app or iOS app was installed or restarted.

Before/after screenshots are attached. Kept as a draft for Stephen's review.

Signed-off-by: Stephen DeLorme <stephen@d.elor.me>
@github-actions

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is f78a32cf03aa90b0da36b44d075daecd8f85d7d8...e855fd74ba96c8f86d685e47e9803f7b5393e047.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review e855fd74ba96c8f86d685e47e9803f7b5393e047 to authorize a new review.
Any previous review applies only to its recorded range.

@sbddesign

Copy link
Copy Markdown
Contributor Author

Sidebar community icon

Reported before

User-provided desktop screenshot: the profile card displays the default bee beside the locally configured community name.

00-reported-before

After: normal profile card

Chromium with the mock native bridge returning a lightning SVG on a red background. The smaller profile-card icon preserves the relay's artwork and background color.

01-profile-card

After: account menu

The same relay icon appears in the existing account menu.

02-profile-menu

After: hover with a user status

Hovering the card reveals the community label with the same lightning icon while the saved status is present.

03-status-hover

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Community name remains device-local instead of syncing from relay

1 participant