fix(desktop): keep Inbox dot for viewed mentions - #7665
Draft
danielblazevski-square wants to merge 0 commit into
Draft
danielblazevski-square wants to merge 0 commit into
danielblazevski-square wants to merge 0 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Buzz marks a mention as read when it arrives in the conversation a person is viewing. The Inbox count stays unchanged, but the sidebar gives no strong signal that the mention arrived.
What
Keep a separate attention dot on Inbox until the person opens Inbox. Keep the numeric unread count unchanged.
Rename “Home badge” to “Inbox badge” so Settings matches the sidebar.
How
Store the mention IDs already seen in Inbox. Show the dot when the feed contains a newer mention, then clear it when Inbox opens.
Risk
The change affects desktop sidebar presentation and local notification state. It does not change relay events or unread-count semantics.
Testing
pnpm exec playwright test tests/e2e/badge.spec.ts --project=smoke --grep 'mention in the open thread keeps an attention dot on Inbox'— 1 passed.Bigger picture
This builds on the read-state behavior in #6153.
Originating Buzz thread:
buzz://message?channel=3a4eadf6-64ee-4bde-9f50-36d665f5cfc2&id=03b47c0dd13164ef44e96475b617688fef09e7a6e6b4f32059533040251b4117&thread=03b47c0dd13164ef44e96475b617688fef09e7a6e6b4f32059533040251b4117Generated with Codex