fix(desktop): remember Inbox unread-only choice - #7672
Open
ngthuydiem wants to merge 1 commit into
Open
ngthuydiem wants to merge 1 commit into
ngthuydiem wants to merge 1 commit into
Conversation
Signed-off-by: Diem Nguyen <diem@squareup.com>
🔐 Codex Security Review
|
ngthuydiem
added a commit
that referenced
this pull request
Sep 15, 2026
ngthuydiem
marked this pull request as ready for review
September 15, 2026 20:54
ngthuydiem
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inbox forgets the Show unread only choice after navigation or restart. Save the toggle with the existing safe storage helpers and restore it when Inbox opens.
The preference stays on this installation and applies across accounts and communities. Fresh installations keep the current off default. If storage fails, the current view remains usable, but the choice may not survive navigation.
Related issue
Related report: #3669.
Overlaps with #6105 and #3682. #6151 also persists category filters and pane widths. This draft keeps the change to the unread toggle and reuses the existing storage helpers.
Testing
The mock Desktop regression passed: enable the toggle, navigate to Agents and back, reload, then repeat with the toggle disabled. Both choices were restored. This exercises the UI with a synthetic fixture; a native app restart was not tested.
The full local repository CI gate is pending. Keep this PR in draft until validation completes.
Before and after behavior
Same synthetic Desktop fixture in Chromium, 1280×720, on macOS. Before: production source from
41c5ace93740261ee5a5d962c2a17e8d846c2c1b. After: PR headb50c1a06d53fdc080e7aae6ee9aa2e9ad6b60a82. The capture test asserted the displayed toggle state before taking each screenshot.Before the fix the toggle is off after both journeys; after the fix it stays on. These are mock-backed UI captures, not a native Desktop restart or live relay test.
Generated with Codex