Serialize strings with an allocator of their own - #366
Merged
gennaroprota merged 1 commit intoAug 7, 2026
Conversation
The archives implement primitives for `std::string` and `std::wstring` only, so a `basic_string` with an allocator of its own, `std::pmr::string` being the usual case, could be serialized only by declaring it `primitive_type`. That declaration states the archive already handles the type, which is untrue here, and the generic fallbacks silently truncated the string at the first whitespace or, for the binary archives, copied its bytes. Such a string now borrows the primitive of the correspondingly built default allocated string, so it needs no declaration at all. The name passed to `make_nvp` is null, which keeps the representation identical to that of `std::string` in every archive, xml included, and lets the two interoperate. Fixes #267.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The archives implement primitives for
std::stringandstd::wstringonly, so abasic_stringwith an allocator of its own,std::pmr::stringbeing the usual case, could be serialized only by declaring itprimitive_type. That declaration states the archive already handles the type, which is untrue here, and the generic fallbacks silently truncated the string at the first whitespace or, for the binary archives, copied its bytes.Such a string now borrows the primitive of the correspondingly built default allocated string, so it needs no declaration at all. The name passed to
make_nvpis null, which keeps the representation identical to that ofstd::stringin every archive, xml included, and lets the two interoperate.Fixes #267.