Stop the shared pointer helper from declaring a load overload - #372
Merged
gennaroprota merged 1 commit intoAug 7, 2026
Merged
Conversation
The declaration existed only to let the load functions in shared_ptr.hpp and shared_ptr_132.hpp be granted friendship, and it was malformed: it contained `SPT< class U >`, which is an elaborated type specifier, so it declared an undefined class `boost::serialization::U` and pinned the parameter to `SPT<U>` for that one type. Deducing against it forms types such as `std::optional<U>`, whose instantiation needs `U` complete, so serializing a `std::optional` alongside `shared_ptr.hpp` failed to compile under GCC. But repairing the declaration was not enough: the corrected declaration matched every class template taking a single type argument, and turned ambiguous against the `load` for `std::vector`. So, this drops the declaration and the friendship together instead, leaving public the members the two headers reach for, as they already were for Microsoft and Sun compilers. Fixes #319.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The declaration existed only to let the load functions in shared_ptr.hpp and shared_ptr_132.hpp be granted friendship, and it was malformed: it contained
SPT< class U >, which is an elaborated type specifier, so it declared an undefined classboost::serialization::Uand pinned the parameter toSPT<U>for that one type. Deducing against it forms types such asstd::optional<U>, whose instantiation needsUcomplete, so serializing astd::optionalalongsideshared_ptr.hppfailed to compile under GCC.But repairing the declaration was not enough: the corrected declaration matched every class template taking a single type argument, and turned ambiguous against the
loadforstd::vector. So, this drops the declaration and the friendship together instead, leaving public the members the two headers reach for, as they already were for Microsoft and Sun compilers.Fixes #319.