chore(i18n): Commit locale JS and drop properties - #783
Open
jackiejou wants to merge 1 commit into
Open
Conversation
Locale maps are now tracked under i18n/{locale}.js. Webpack and
createIntl read those files. formatjs extract replaces the Babel
plugin. Removing properties switches the localization job to New Mode.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i18n/{locale}.jsmaps and pointed webpack at those filesprops2es,babel-plugin-react-intl, andTranslationsPluginyarn extract:i18nvia@formatjs/cli.propertiesfiles so the localization job switches to formatjs extractWhy
This repo already used react-intl in source. The remaining work was the Legacy to New Mode pipeline cutover: locale JS is the runtime source, and deleting
.propertiesis the signal for the localization job to extract fromdefineMessagesand recommit locale files.The committed JS files are a seed from the last properties conversion. The next localization run will overwrite them in the job format (empty
en-US.js, generated-file banner on other locales).Test plan
yarn extract:i18nmatches all 22 source stringsbox-annotations/i18n/en-USand loads the 22 keys