fix(content-uploader): localize upload error messages in modernized panel - #4739
Conversation
…anel The modernized uploads panel surfaced the raw API error message, which is returned in the request locale rather than the user's Box language. Error codes now resolve against the message catalog first, falling back to the API message and then a generic failure. Extracts the error-code-to-message mapping out of progressCellRenderer into a shared util so the legacy and modernized paths stay in sync, and adds a ModernizedUploadsManager wrapper that can read intl from context (ContentUploader renders above IntlProvider).
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe uploader now renders a typed ChangesUploader modernization
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ContentUploader
participant ModernizedUploadsManager
participant mapToModernizedUploadItems
participant UploadsManagerBP
ContentUploader->>ModernizedUploadsManager: pass raw upload items and manager props
ModernizedUploadsManager->>mapToModernizedUploadItems: map items with rootFolderId, ETA, and intl
ModernizedUploadsManager->>UploadsManagerBP: render mapped items and remaining props
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Merge Queue Status
This pull request spent 12 minutes 16 seconds in the queue, including 11 minutes 58 seconds running CI. Required conditions to merge
|
The modernized uploads panel surfaced the raw API error message, which is returned in the request locale rather than the user's Box language. Error codes now resolve against the message catalog first, falling back to the API message and then a generic failure.
Extracts the error-code-to-message mapping out of
progressCellRendererinto a shared util so the legacy and modernized paths stay in sync, and adds aModernizedUploadsManagerwrapper that can read intl from context (ContentUploader renders above IntlProvider).Summary by CodeRabbit
New Features
Bug Fixes
Tests