Skip to content

chore(deps): bump immutable - #4746

Closed
jpan-box wants to merge 1 commit into
box:masterfrom
jpan-box:chore-cleanup-immutable-lockfile
Closed

jpan-box wants to merge 1 commit into
box:masterfrom
jpan-box:chore-cleanup-immutable-lockfile

Conversation

@jpan-box

@jpan-box jpan-box commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Ensure nested immutable under draft-js resolves to ^3.8.3 and drop the stale 3.7.6 lockfile entry.

Why a resolution

  • draft-js / @types/draft-js pin immutable@~3.7.4.
  • A normal bump can't reach the patched 3.x line for those nested deps.
  • Top-level immutable@^4 (sass/devDependency) must stay on v4, so the override is scoped under draft-js (not a global pin).

Dep chain:

yarn why v1.22.22
[1/4] Why do we have the module "immutable"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
info 
=> Found "immutable@4.3.9"
info Has been hoisted to "immutable"
info Reasons this module exists
   - Specified in "devDependencies"
   - Hoisted from "sass#immutable"
info Disk size without dependencies: "784KB"
info Disk size with unique dependencies: "784KB"
info Disk size with transitive dependencies: "784KB"
info Number of shared dependencies: 0
info 
=> Found "@types/draft-js#immutable@3.8.3"
info This module exists because "@types#draft-js" depends on it.
info Disk size without dependencies: "464KB"
info Disk size with unique dependencies: "464KB"
info Disk size with transitive dependencies: "464KB"
info Number of shared dependencies: 0
info 
=> Found "draft-js#immutable@3.8.3"
info This module exists because "draft-js" depends on it.
info Disk size without dependencies: "464KB"
info Disk size with unique dependencies: "464KB"
info Disk size with transitive dependencies: "464KB"
info Number of shared dependencies: 0
Done in 0.43s.

Steps taken

  1. Added @types/draft-js/immutable resolution (^3.8.3) alongside existing draft-js/immutable; merged the stale immutable@~3.7.4 lock entry onto 3.8.3 (removed 3.7.6).
  2. yarn install — Already up-to-date.
  3. npx yarn-deduplicate yarn.lock then yarn install — lockfile stable.
  4. yarn audit — no immutable versions below 3.8.3 remain in yarn.lock (nested installs resolve to 3.8.3; top-level dev/sass stays on 4.3.9).
  5. Full test suite passes (976 suites, 11527 tests).

Summary by CodeRabbit

  • Chores
    • Added a package resolution to improve compatibility with Draft.js type definitions.
    • Preserved the existing tar package resolution.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jpan-box
jpan-box requested a review from a team as a code owner August 4, 2026 20:07
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5571bb16-b105-4996-bcbd-c8b30f5c4180

📥 Commits

Reviewing files that changed from the base of the PR and between a0eec89 and d508b21.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json

Walkthrough

The package configuration adds an explicit @types/draft-js/immutable resolution and keeps the existing tar resolution.

Changes

Dependency resolution

Layer / File(s) Summary
Add immutable type resolution
package.json
Adds the @types/draft-js/immutable package resolution. The existing tar resolution remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: ready-to-merge

Suggested reviewers: tjuanitas

Poem

A rabbit checks the lockfile tonight,
One type resolution now sits right.
The tar entry stays in view,
With tidy changes, small and true.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dependency change and matches the pull request objective.
Description check ✅ Passed The description explains the resolution changes, rationale, validation steps, and test results in sufficient detail.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jpan-box
jpan-box marked this pull request as draft August 4, 2026 20:12
@jpan-box jpan-box closed this Aug 4, 2026
@jpan-box

jpan-box commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Closing — covered by #4736 (lockfile already drops the stale immutable 3.7.6 entry).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant