refactor(scroll-wrapper): migrate ScrollWrapper from Flow to TypeScript - #4780
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
WalkthroughAdded a typed ChangesScrollWrapper migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to This is a localized type-system migration with reported passing tests and validation checks; no actionable merge-blocking risk remains beyond normal review. Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
47c1522 to
90ab30e
Compare
Merge Queue Status
This pull request spent 13 minutes 31 seconds in the queue, including 13 minutes 9 seconds running CI. Required conditions to merge
|
Convert
ScrollWrappercomponent to TypeScriptThis PR converts
src/components/scroll-wrapperfrom JavaScript with Flow to TypeScript.Changes
ScrollWrapper.jstoScrollWrapper.tsxwith exportedScrollWrapperPropsinterfaceindex.jstoindex.ts, re-exporting the component and its typesScrollWrapper.test.jstoScrollWrapper.test.tsx.js.flowfiles for backward compatibilityContract
Testing
yarn lint,yarn lint:ts, andflow checkpassSummary by CodeRabbit