fix(content-uploader): show locked file error in uploads manager - #4831
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe change adds shared metadata, error, and waveform constants. It also adds locked-upload error localization, resolver handling, and test coverage. ChangesConstants and locked upload handling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change correctly maps locked-upload failures to a localized message and introduces no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Biome (2.5.10)src/constants.jsFile contains syntax errors that prevent linting: Line 9: The 'declare' modifier can only be used in TypeScript files.; Line 15: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 16: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 17: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 18: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 21: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 22: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 23: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 24: type annotation are a TypeScript only feature ... [truncated 19110 characters] ... TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 547: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 548: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 549: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 550: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 551: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax.; Line 552: type annotation are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit saw the lock and paused, Comment |
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 13 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
Uploading a new version of a locked file returned a 403 with code access_denied_item_locked, which had no dedicated copy and fell back to the generic upload failure message. Map it to "File is locked" so the row explains the cause. Both the legacy and modernized uploads manager read this mapping. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dc950f8 to
a5cd071
Compare
Uploading a new version of a locked file returned a 403 with code access_denied_item_locked, which had no dedicated copy and fell back to the generic upload failure message. Map it to "File is locked" so the row explains the cause. Both the legacy and modernized uploads manager read this mapping.
Summary by CodeRabbit
Bug Fixes
Tests