Skip to content

Add competency fixture for same-named settings #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bpstr wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add competency fixture for same-named settings #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/fixtures/competency/same-setting-names/SCENARIO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Same setting name in unrelated packages

Question: Which upload limit controls media uploads?

Expected: identify `media/settings.py:UPLOAD_LIMIT_MB` and its validator; do not merge it with the unrelated admin setting. Record separate concepts even though the identifier is identical.
4 changes: 4 additions & 0 deletions tests/fixtures/competency/same-setting-names/admin/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
UPLOAD_LIMIT_MB = 10

def validate_admin_upload(size_mb):
return size_mb <= UPLOAD_LIMIT_MB
4 changes: 4 additions & 0 deletions tests/fixtures/competency/same-setting-names/media/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
UPLOAD_LIMIT_MB = 250

def validate_media_upload(size_mb):
return size_mb <= UPLOAD_LIMIT_MB
Loading