Skip to content

fix(pg): strip IPv6 URI brackets from host at connect/lookup, not in the parser #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spokodev wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

fix(pg): strip IPv6 URI brackets from host at connect/lookup, not in the parser #3698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pg-connection-string/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function parse(str, options = {}) {
config.client_encoding = result.searchParams.get('encoding')
return config
}
const hostname = dummyHost ? '' : result.hostname
const hostname = (dummyHost ? '' : result.hostname).replace(/^\[(.+)\]$/, '$1')
if (!config.host) {
// Only set the host if there is no equivalent query param.
config.host = decodeURIComponent(hostname)
Expand Down
5 changes: 5 additions & 0 deletions packages/pg-connection-string/test/parse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ describe('parse', function () {
subject.database?.should.equal('lala')
})

it('strips the URI brackets from an IPv6 host', function () {
parse('postgres://brian:pw@[::1]:5432/lala').host?.should.equal('::1')
parse('postgres://brian:pw@[2001:db8::1]:5432/lala').host?.should.equal('2001:db8::1')
})

it('escape spaces if present', function () {
const subject = parse('postgres://localhost/post gres')
subject.database?.should.equal('post gres')
Expand Down
Loading