fix: terminate bash process groups on timeout - #304
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bub | 1970ffb | Commit Preview URL Branch Preview URL |
Sep 13 2026, 12:09 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash timeouts currently terminate only the shell, leaving descendants running and holding stdout/stderr pipes open. For example,
sleep 6 & echo CHILD_PID=$!; waitwith a one-second timeout took 6.07 seconds to return; the child was still alive after the shell received SIGTERM.This change starts commands in a separate POSIX session and terminates the process group, allowing three seconds for SIGTERM before escalating to SIGKILL. Cleanup also handles descendants whose shell has already exited and bounds output draining to one second. Output finalization now propagates caller cancellation while preserving reader tasks for cleanup.
bash.killalways uses termination, including when the shell leader has exited; cancellation andquitshare the same cleanup implementation.The bash tool description documents timeout cleanup and its limits. Descendants that create their own sessions are outside the group; Windows retains single-process termination. Background commands continue to ignore
timeout_seconds.Validation:
git diff --checkpassed.