watchdog: skip notification registration when device lacks interrupt support - #587
Open
dmcgougan wants to merge 1 commit into
Open
watchdog: skip notification registration when device lacks interrupt support#587dmcgougan wants to merge 1 commit into
dmcgougan wants to merge 1 commit into
Conversation
…support ATmega128 has no watchdog interrupt and represents it with vector zero as a placeholder. Registering a notification for that placeholder causes simavr to crash during an ATmega128 reset. Add a guard in the watchdog code to fix the crash and also a host regression test for reset on ATmega128.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATmega128 has no watchdog interrupt and represents it with vector zero as a placeholder. Registering a notification for that placeholder causes simavr to crash during an ATmega128 reset.
Add a guard in the watchdog code to fix the crash and also a host regression test for reset on ATmega128.