fix(rust): fully qualify Option and Result types - #1676
Merged
Conversation
When expanding the wit `option` and `result` types to rust, they were printed as `Option` and `Result` respectively. This can cause collisions with locally defined types that happen to share the same name. For example: ``` type %result = bool; // should return a result, but is generated returning the local alias no-clobber: func() -> result<_, _>; ``` The generated types for `option` and `result` now expand to `::core::option::Option` and `::core::result::Result`. Signed-off-by: Scott Andrews <scott@andrews.me>
pchickey
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When expanding the wit
optionandresulttypes to rust, they were printed asOptionandResultrespectively. This can cause collisions with locally defined types that happen to share the same name.For example:
The generated types for
optionandresultnow expand to::core::option::Optionand::core::result::Result.