fix(test): preserve colliding diagnostic artifacts - #2507
Open
PLASMA-FR wants to merge 1 commit into
Open
Conversation
Member
|
No code findings at 8f6acb1. Artifact allocation preserves colliding diagnostics, existing attempt files and manifests, with regression coverage for ordering and duplicate logs. There are no conflicts; ready for human review. The iOS smoke check still fails because a depth-1 snapshot falls back to XCTest and carries unexpected tree-quality metadata; this appears unrelated to artifact copying, but the check needs to pass before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-device test ./flows --artifacts-dir ./outcould silently lose diagnostic files: copying twodevice.logfiles generateddevice-2.log, which a later artifact with that name overwrote. Diagnostics could also overwritereplay.ador the timing trace, or disappear under the final manifests.This completes the existing attempt-artifact retention contract from #266 and the replay documentation. The artifact writer now chooses unused numbered names, reserves manifest names, preserves files already in the attempt directory, and deduplicates failure logs.
result.txtlists the retained filenames. Five files change, including regressions, help, docs, and changelog.Validation
Tested
8f6acb16e39cea991df6f1611a43aef5edcbc8a2with Node 24.13.1 and pnpm 11.17.0 on Linux:pnpm exec vitest runover the focused replay/suite/startup files: 87 tests pass.pnpm build,pnpm check:command-docs, and builttest --helppass.pnpm check:affected --run: all runnable checks pass, including 2,801 tests across 384 files.CI pending; no local device run. The changed boundary copies files after an attempt completes.