fix(diff): include maximum RGB distance at threshold one - #2508
Merged
thymikee merged 1 commit intoSep 12, 2026
Merged
Conversation
Member
|
No code findings at cc92eb9. The maximum RGB distance now follows the same rounding as the pixel comparison, and the regressions cover threshold 1 and the boundary immediately below it. Current-head checks pass and there are no conflicts; ready for human review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-device diff screenshot --baseline black.png white.png --threshold 1reported 100% different pixels instead of a match. The maximum RGB distance rounded one floating-point step below the per-pixel calculation.Use the same square-root calculation for the maximum. This completes the existing Euclidean comparison and saved-image workflow from #214 and #404; thresholds below 1 still detect maximum contrasts. Five files change: the calculation, regression tests, command help, and documentation.
Validation
Tested
cc92eb97d6c07314b87641aa19ff10ae516def59with Node 24.13.1 and pnpm 11.17.0 on Linux:pnpm buildandpnpm check:command-docspass (12 documentation tests).pnpm check:affected --run: all runnable checks pass, including 3,062 tests across 414 files.CI pending. Saved-image comparisons require no device; no local native run.