refactor(snapshot): drop the bridge truncation dimension; stop promising --scope for depth caps - #2511
Open
thymikee wants to merge 1 commit into
Open
Conversation
…ing --scope for depth caps The dimension and limit the bridge adapter inferred for a cut capture had no renderer and one consumer, the comparison-identity string, where the kind alone gives the same comparability. The runner never produced them. The depth-cap warning suggested --scope to read deeper content; on iOS scope narrows presentation and acquisition stays scope-blind.
Size Report
Startup median (7 runs, lower is better):
|
thymikee
added this pull request to stack #2513
September 12, 2026 12:07
Member
Author
|
No code findings in the cleanup layer at 2e9dedb. Removing inferred truncation dimensions preserves the complete-versus-truncated comparison, and the depth warning no longer promises an acquisition change from --scope. There are no conflicts, but merge depends on the warning correction in #2510. The iOS smoke failure is automation-longpress not becoming visible after scrolling; it appears unrelated to this layer’s residue/copy changes and still needs resolution before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2510 (merge that first; this diff is the top commit). Second-order cleanup after the shared truncation disclosure.
Drop the truncation dimension inference
The bridge adapter guessed a truncation
dimension(nodes/depth/payload) andlimitfrom counts and put them in the acquisition residue. Nothing rendered them: residue never reaches the CLI, and the only consumer was the comparison-identity string inios-snapshot-planning.ts, where{ kind: 'truncated' }yields the same comparability (two cut captures compare equal; a cut and a complete one do not). The runner never produced the field.IosTruncationDimensionand the inference function are gone;createAcquisitionandcreateAcquisitionResiduelose the parameters that only fed it.Depth-cap warning stops promising
--scopeThe copy said "Re-run with
--depth N --scope <container>only if you need deeper content." On iOS, scope narrows the presented view; acquisition is scope-blind, and the private AX ladder already extends depth on its own. The warning now says the backend capped the tree and what to do instead (navigate so the content sits higher; screenshot for the rest), the same shape as the new truncation disclosure.Tests: residue fixtures updated; the three depth-copy assertions updated. Lint, fallow, typecheck green.