test(expo-template): make tests and checks runnable - #578
Merged
thiagobrez merged 3 commits intoSep 9, 2026
Merged
Conversation
thiagobrez
reviewed
Sep 9, 2026
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>
thiagobrez
approved these changes
Sep 9, 2026
…checks-runnable # Conflicts: # yarn.lock
oleksandrzavarzin-callstack
deleted the
fix/make-tests-and-checks-runnable
branch
September 10, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
The Expo template's only test failed on a fresh scaffold, the script running it couldn't report
that failure, and nothing linted or typechecked the template at all.
The test was broken.
ThemedText-test.tsxusedreact-test-renderer, which returnsnullfrom
.toJSON()under React 19, asserted against a snapshot generated by an older React. Rewrittenwith
@testing-library/react-nativev14 and the stale snapshot is deleted."test": "jest --watchAll"never exited. WithCI=trueand stdin closed it ran the suite,printed the interactive watch hint, and parked forever waiting for a keypress; no exit code, so a
failing test reported nothing. Split into
test/test:watch.No lint, no typecheck. The template defined neither script and shipped no eslint config.
Added
lint(expo lint) andtypecheck(tsc --noEmit), plus theeslint.config.js.4 lint errors in the template's own copy (
react/no-unescaped-entitieson apostrophes) areescaped, so
npm run lintis green on a fresh scaffold.yarn lint/yarn typecheckat the repo root now skip this package. That's deliberate: the rootpins
@types/reactthroughresolutionswhile the template declares its own, so checking itin-place reports results no user ever sees.
CONTRIBUTING.mdexplains this and documents thepack-and-scaffold flow instead.
Important
Merge after #577 - align dependencies with Expo SDK 54>. This branch is off
main, so the twotype errors that PR fixes are still present here; until it lands, the
typecheckscript this PRadds fails on a scaffolded app.
How to test?
npm run lint→ exit 0CI=true npm test→ exits, and exits 0 (before: hung indefinitely)npm run typecheck→ clean, once PR fix(expo-template): align dependencies with Expo SDK 54 #577 is in.yarn lint && yarn typecheckat the repo root still pass, with the template excluded.Screenshots
Not applicable - no runtime or UI change.