fix: rename misspelled props and various typos - #5117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow-up to a review comment on #5099, where it was pointed out that
Searchbarhas a prop calledtraileringIcon, which is a typo fortrailing.This PR:
Searchbarprops to their correct spelling (breaking change):traileringIcon→trailingIcontraileringIconColor→trailingIconColortraileringIconAccessibilityLabel→trailingIconAccessibilityLabelonTraileringIconPress→onTrailingIconPressoverridenTheme→overriddenTheme(local variable inSurface.tsx)drawabale→drawable(JSDoc comment repeated across 9 components)densed→dense,intefere→interfere(JSDoc comments)desctiption→description,uncheked→unchecked,specifed→specified(test titles)Screenhot→Screenshot(local function in the docs site)elevarion→elevation(docs site theming table data)platfrom,Additionaly,oficially,follwing(docs guide prose)Related issue
Follow-up requested in this review comment on #5099 ("remove derived testIDs"). No standalone issue exists for this.
Screenshots / Videos
Not applicable, this is a rename/typo-fix change with no visual or behavioral impact. Component render output is unchanged.
Test plan
yarn tsc --noEmit- no type errors.yarn jest src/components/__tests__/Searchbar.test.tsx src/components/__tests__/ListUtils.test.tsx src/components/__tests__/SegmentedButton.test.tsx src/components/__tests__/Appbar/Appbar.test.tsx src/components/__tests__/Surface.test.tsx- all suites pass, including updatedSearchbarprop-name assertions and existing snapshots.grepfortrailering/Traileringand the other fixed misspellings confirms no remaining occurrences outside of thedocs/6.xmigration guide, where the old name is intentionally shown as the "before" side of the rename example.docs/6.x/docs/guides/migration.mddocumenting the prop rename as a breaking change, with a before/after diff.docs/5.x(frozen v5 docs) intentionally left untouched.