Skip to content

fix: rename misspelled props and various typos - #5117

Merged
satya164 merged 1 commit into
callstack:mainfrom
k0ndee:@k0ndee/typos
Sep 11, 2026
Merged

fix: rename misspelled props and various typos#5117
satya164 merged 1 commit into
callstack:mainfrom
k0ndee:@k0ndee/typos

Conversation

@k0ndee

@k0ndee k0ndee commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Motivation

This is a follow-up to a review comment on #5099, where it was pointed out that Searchbar has a prop called traileringIcon, which is a typo for trailing.

This PR:

  • Renames the misspelled Searchbar props to their correct spelling (breaking change):
    • traileringIcontrailingIcon
    • traileringIconColortrailingIconColor
    • traileringIconAccessibilityLabeltrailingIconAccessibilityLabel
    • onTraileringIconPressonTrailingIconPress
  • Fixes a batch of other typos found while scanning the repo, all internal-only (JSDoc comments, test titles, docs guide prose, an internal variable name, and docs-site-only code/data) so none of them affect the public API:
    • overridenThemeoverriddenTheme (local variable in Surface.tsx)
    • drawabaledrawable (JSDoc comment repeated across 9 components)
    • denseddense, intefereinterfere (JSDoc comments)
    • desctiptiondescription, unchekedunchecked, specifedspecified (test titles)
    • ScreenhotScreenshot (local function in the docs site)
    • elevarionelevation (docs site theming table data)
    • platfrom, Additionaly, oficially, follwing (docs guide prose)

Related issue

Follow-up requested in this review comment on #5099 ("remove derived testIDs"). No standalone issue exists for this.

Screenshots / Videos

Not applicable, this is a rename/typo-fix change with no visual or behavioral impact. Component render output is unchanged.

Test plan

  • yarn tsc --noEmit - no type errors.
  • yarn jest src/components/__tests__/Searchbar.test.tsx src/components/__tests__/ListUtils.test.tsx src/components/__tests__/SegmentedButton.test.tsx src/components/__tests__/Appbar/Appbar.test.tsx src/components/__tests__/Surface.test.tsx - all suites pass, including updated Searchbar prop-name assertions and existing snapshots.
  • Repo-wide grep for trailering/Trailering and the other fixed misspellings confirms no remaining occurrences outside of the docs/6.x migration guide, where the old name is intentionally shown as the "before" side of the rename example.
  • Added a "Searchbar" section to docs/6.x/docs/guides/migration.md documenting the prop rename as a breaking change, with a before/after diff.
  • docs/5.x (frozen v5 docs) intentionally left untouched.

@satya164 satya164 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@satya164
satya164 merged commit 31d8c58 into callstack:main Sep 11, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants