Fix Google Calendar Obsidian link escaping - #2102
Closed
martin-forge wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing this — I tested the premise and it does not hold. I created two Google Calendar events, one storing a raw
So this change fixes nothing I could reproduce and breaks the link in TaskNotes itself. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&file=.Why
Google Calendar descriptions are HTML-capable. Leaving the raw
&file=separator in the description can be handled as an HTML entity boundary by Calendar clients, which breaks the Obsidian open link path parameter.Testing
npm test -- --runTestsByPath tests/services/TaskCalendarSyncService.test.tsnpm run build:testnpm run lint