Move code to namespace com.sap.cds, version adjustments - #39
Open
lisajulia wants to merge 13 commits into
Open
Conversation
lisajulia
changed the title
![hyperspace-pr-bot[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The PR makes straightforward upgrades (JDK 17→21, CDS 4→5, Spring Boot 3→4, package rename) but the migration to Spring Boot 4.x's restructured MockMvc test support introduces a likely build-breaking issue: the declared artifact spring-boot-starter-webmvc-test does not appear to be a valid Spring Boot artifact, and the paired import change in IntegrationTest.java will fail to compile if the artifact coordinates are wrong. These two related issues are the most critical items to resolve before merging.
PR Bot Information
Version: 1.29.54
- Correlation ID:
e385ce90-a2ba-11f1-8376-8b9aac03b0a9 - Event Trigger:
pull_request.opened - LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4 to 5. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-java dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@sap/eslint-plugin-cds](https://cap.cloud.sap/) from 4.1.0 to 4.1.1. --- updated-dependencies: - dependency-name: "@sap/eslint-plugin-cds" dependency-version: 4.1.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.apache.maven.plugins:maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.14.1 to 3.15.0. - [Release notes](https://github.com/apache/maven-compiler-plugin/releases) - [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.14.1...maven-compiler-plugin-3.15.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-compiler-plugin dependency-version: 3.15.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@sap/cds-dk](https://cap.cloud.sap/) from 9.4.2 to 9.7.1. --- updated-dependencies: - dependency-name: "@sap/cds-dk" dependency-version: 9.7.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.1 to 10.0.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.1...v10.0.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
lisajulia
removed
the
no changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency Updates, Java 21 Migration & Test Fixes
Chore
🔧 Updated project dependencies to their latest versions, migrated from JDK 17 to JDK 21, upgraded to Spring Boot 4.x and CDS Services 5.x, and fixed test and package naming issues.
Changes
pom.xml&samples/bookshop/pom.xml: Bumped JDK version from 17 to 21,cds.services.versionto5.0.0,spring.boot.versionto4.1.0,maven-compiler-pluginto3.14.0, andmaven-surefire-pluginto3.5.6. Updated the enforcer plugin'srequireJavaVersionrule to use[21,)instead of the property variable.samples/bookshop/app/index.html: Pinned SAPUI5 script URLs to a specific version (1.148.2) instead of using the unversioned latest endpoint.samples/bookshop/srv/pom.xml: Addedspring-boot-starter-webmvc-testas a test dependency.samples/bookshop/srv/src/test/java/customer/bookshop/ApplicationTest.java: Removed unnecessary@AutoConfigureMockMvcimport and annotation.samples/bookshop/srv/src/test/java/customer/bookshop/IntegrationTest.java: Updated@AutoConfigureMockMvcimport to the new Spring Boot 4.x packageorg.springframework.boot.webmvc.test.autoconfigure.AutoConfigureMockMvc.srv/src/main/java/com/sap/cds/feature/emoji/EmojiHandler.java: Renamed/moved fromsap.capire.emoji_plugintocom.sap.cds.feature.emojipackage; cleaned up duplicate imports.srv/src/main/java/com/sap/cds/feature/emoji/EmojiHandlerRuntimeConfiguration.java: Updated package declaration fromsap.capire.emoji_plugintocom.sap.cds.feature.emoji.srv/src/main/resources/META-INF/services/com.sap.cds.services.runtime.CdsRuntimeConfiguration: Updated the service registration entry to reflect the new fully-qualified class namecom.sap.cds.feature.emoji.EmojiHandlerRuntimeConfiguration.PR Bot Information
Version:
1.29.54e385ce90-a2ba-11f1-8376-8b9aac03b0a9anthropic--claude-4.6-sonnetpull_request.opened