Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed change addresses stale frame tracking after device loss.
Pull request overview
Resets pending picking readback frame tracking during initialization and device resource release, preventing stale frame indices after device loss.
Changes:
- Initializes
m_frameIndexto zero. - Clears
m_frameIndexwhen resources are released.
File summaries
| File | Description |
|---|---|
trinity/Eve/EvePicking.cpp |
Resets picking readback frame state during initialization and resource release. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if device loss happens and a picking readback is bound the frame index doesnt get reset with the main frame causing the readback to be blocked until client catches up to previous latest frame during picking