Apply a linked theme's palettes to scheme islands stamped inside a card - #6207
Draft
burieberry wants to merge 7 commits into
Draft
burieberry wants to merge 7 commits into
burieberry wants to merge 7 commits into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…swatches Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…r own file Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…n scheme island tests Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…iner's scheme Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
… mixed scheme markers Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
data-theme="dark"(or.dark) stamped inside a themed card's template only got thetheme.cssdark defaults: the style container query that applies a theme'sdarkModeVariablesresolves against the scope element's ancestors, so it never saw an island below it. Themed instances rendered dark Boxel surfaces with the theme's light accents.themeScopedCssre-emits both palettes on scheme islands via an@scopeblock bounded at the next themed card, so a nested card's islands keep its own theme.theme.cssrepeats the chrome-knob boundary reset on islands, so buttons inside an island hover and border with the theme's tokens like the rest of the card, instead of snapping back to Boxel chrome colors.Fixes CS-12988.
🤖 Generated with Claude Code