Skip to content

Apply a linked theme's palettes to scheme islands stamped inside a card - #6207

Draft
burieberry wants to merge 7 commits into
mainfrom
cs-12988-in-card-data-theme-dark-variables
Draft

burieberry wants to merge 7 commits into
mainfrom
cs-12988-in-card-data-theme-dark-variables

Conversation

@burieberry

@burieberry burieberry commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

A data-theme="dark" (or .dark) stamped inside a themed card's template only got the theme.css dark defaults: the style container query that applies a theme's darkModeVariables resolves against the scope element's ancestors, so it never saw an island below it. Themed instances rendered dark Boxel surfaces with the theme's light accents.

  • themeScopedCss re-emits both palettes on scheme islands via an @scope block bounded at the next themed card, so a nested card's islands keep its own theme.
  • theme.css repeats the chrome-knob boundary reset on islands, so buttons inside an island hover and border with the theme's tokens like the rest of the card, instead of snapping back to Boxel chrome colors.
  • New acceptance suite covers islands, nested islands by attribute and by class, and a nested themed card's own island.

Fixes CS-12988.

🤖 Generated with Claude Code

islands-1 islands-2

burieberry and others added 5 commits September 18, 2026 17:16
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…swatches

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…r own file

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…n scheme island tests

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…iner's scheme

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Preview deployments

Host Test Results

    1 files      1 suites   2h 8m 19s ⏱️
4 918 tests 4 904 ✅ 14 💤 0 ❌
4 933 runs  4 919 ✅ 14 💤 0 ❌

Results for commit 88fe61d.

Realm Server Test Results

    1 files    244 suites   1h 27m 7s ⏱️
3 618 tests 3 618 ✅ 0 💤 0 ❌
3 669 runs  3 669 ✅ 0 💤 0 ❌

Results for commit 88fe61d.

burieberry and others added 2 commits September 18, 2026 17:53
… mixed scheme markers

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant