Declare date-fns in base, which imports it - #6220
Merged
Merged
Conversation
`date.gts` and `datetime.gts` import `date-fns`, and `packages/base` never declared it. It works today because the host shims `date-fns` on the virtual network, so base modules fetched from the realm resolve it at runtime — but pnpm links only declared dependencies, so the package is absent from `packages/base/node_modules` and anything resolving base's imports at build time cannot find it. Declaring it through the catalog costs nothing: every importer already resolves to 2.30.0 and this one joins them, which is the whole lockfile diff. Same manifest-honesty gap as ember-provide-consume-context. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
jurgenwerk
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages/base/date.gtsanddatetime.gtsbothimport { … } from 'date-fns', andpackages/base/package.jsonnever declared it.Nothing is broken today. The host shims
date-fnson the virtual network (externals.ts), so a base module fetched from the realm resolves it at runtime through the shim. But pnpm links only declared dependencies, sodate-fnsis absent frompackages/base/node_modules, and anything resolving base's imports at build time rather than runtime cannot find it.That is the same class of gap as
ember-provide-consume-contextin #6183: a manifest that does not describe what the package actually imports, masked by a runtime mechanism.Why now
It blocks two modules in CS-13056. Serving
date/datetimefrom the host bundle compiles base's source against base's own dependencies, and the build fails with:Declaring it is a prerequisite for that work and stands on its own regardless.
Effect
None at runtime. The catalog already pins
date-fns, every existing importer resolves to 2.30.0, and base now joins them — the entire lockfile diff is three added lines underpackages/base.packages/host,packages/runtime-commonandpackages/realm-serverall still resolve to 2.30.0, unchanged.🤖 Generated with Claude Code