CLI-60: Suppress release link auto-open when --yes-always is set - #665
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where the release notes link automatically opens in the browser when the
--yes-alwaysflag is set.Problem
When users run cecli with
--yes-always, cecli still auto-opens the release link in the browser on startup due to auto-answering the first-run prompt. This causes unexpected browser tabs to open in headless/automated contexts.Solution
Modified
cecli/main.py: Updated themain_asyncfunction to skip the automated browser opening logic ifargs.yes_alwaysis True. This ensures that automated testing environments or non-interactive sessions are not interrupted by unexpected browser launches.Specifically changed:
elif args.show_release_notes is None and is_first_run:to
elif args.show_release_notes is None and is_first_run and not args.yes_always:Verification
cecli --yes-alwaysno longer triggers the browser.--yes-always) still opens the link as expected.--show-release-notesstill opens the link.This respects the non-interactive intent of the
--yes-alwaysflag by skipping the release notesoffer_urlprompt when the user has specified "always yes".